feat(otel): otel sampling support in distributed tracing by vpellan · Pull Request #10117 · DataDog/dd-trace-js

vpellan · 2026-09-02T14:21:30Z

What does this PR do?

Add support for OTel sampling in distributed tracing, by reading and emitting ot.th and ot.rv tags. These tags will be forwarded to services using OTel SDKs, that should forward them to the backend.

Motivation

Distributed tracing will work between DD-instrumented services and OTel-instrumented services, downstream OTel services will be able to forward the th field it to the collector and backend, which will calculate metrics correctly

Additional Notes

Locally passes DataDog/system-tests#7518

chatgpt-codex-connector · 2026-09-02T14:21:47Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-09T14:54:20.107437Z	`79fa291`	Manual request
🔒 Security Review	✅ Completed 2026-09-09T14:54:31.837792Z	`79fa291`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

dd-octo-sts · 2026-09-02T14:22:27Z

Overall package size

Self size: 8.87 MB
Deduped: 9.54 MB
No deduping: 9.54 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

datadog-prod-us1-5 · 2026-09-02T14:24:42Z

⚠️ Warnings

⚠️ Your PR has warnings. Tests failed — unable to determine if these are from required jobs.

🧪 3 Tests failed in 1 job

LLMObs | claude-agent-sdk — ❌ 3 tests failed

View more details · View in GitHub Actions

❌

Plugin claude-agent-sdk with @anthropic-ai/claude-agent-sdk >=0.2.113 (0.3.259) instruments a full agentic call with subagents

from with @anthropic-ai/claude-agent-sdk >=0.2.113 (0.3.259)

Timeout of 15000ms exceeded. For async tests and hooks, ensure &#34;done()&#34; is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-claude-agent-sdk/test/index.spec.js)

Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure &#34;done()&#34; is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-claude-agent-sdk/test/index.spec.js)
    at listOnTimeout (node:internal/timers:605:17)
    at process.processTimers (node:internal/timers:541:7)

❌ esm with @anthropic-ai/claude-agent-sdk >=0.2.113 (0.3.259) is instrumented named from with @anthropic-ai/claude-agent-sdk >=0.2.113 (0.3.259)

Timeout of 30000ms exceeded. For async tests and hooks, ensure &#34;done()&#34; is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-claude-agent-sdk/test/integration-test/client.spec.js)

Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure &#34;done()&#34; is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-claude-agent-sdk/test/integration-test/client.spec.js)
    at listOnTimeout (node:internal/timers:605:17)
    at process.processTimers (node:internal/timers:541:7)

❌ esm with @anthropic-ai/claude-agent-sdk >=0.2.113 (0.3.259) is instrumented named-from-namespace from with @anthropic-ai/claude-agent-sdk >=0.2.113 (0.3.259)

Timeout of 30000ms exceeded. For async tests and hooks, ensure &#34;done()&#34; is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-claude-agent-sdk/test/integration-test/client.spec.js)

Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure &#34;done()&#34; is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/packages/datadog-plugin-claude-agent-sdk/test/integration-test/client.spec.js)
    at listOnTimeout (node:internal/timers:605:17)
    at process.processTimers (node:internal/timers:541:7)

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 98.16% (+10.95%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 79fa291 | Docs | View more details | Give us feedback!}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49eb6259f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pr-commenter · 2026-09-02T14:35:47Z

Benchmarks

Benchmark execution time: 2026-09-09 14:47:06

Comparing candidate commit 79fa291 in PR branch vpellan/otel-threshold-random-value with baseline commit 2015713 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2292 metrics, 21 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-with-attacks-20

unstable max_rss_usage [-21.820MB; +3.397MB] or [-12.483%; +1.943%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

unstable max_rss_usage [-12.992MB; +22.992MB] or [-5.675%; +10.043%]

scenario:debugger-line-probe-with-snapshot-minimal-26

unstable max_rss_usage [-7.334MB; +19.983MB] or [-3.039%; +8.279%]

scenario:encoders-0.4-immediate-flush-20

unstable max_rss_usage [-7.849MB; +5.312MB] or [-10.805%; +7.313%]

scenario:llmobs-encode-unicode-ascii-20

unstable cpu_usage_percentage [-19.944%; +12.486%]
unstable execution_time [-314.166ms; +492.812ms] or [-19.932%; +31.266%]
unstable throughput [-3318.046op/s; +2130.834op/s] or [-21.225%; +13.631%]

scenario:llmobs-encode-unicode-mixed-20

unstable max_rss_usage [-14.737MB; +1.784MB] or [-19.246%; +2.330%]

scenario:plugin-aws-sdk-extract-response-body-24

unstable cpu_user_time [-307.058ms; +271.976ms] or [-5.765%; +5.106%]
unstable execution_time [-306.638ms; +271.576ms] or [-5.748%; +5.091%]
unstable throughput [-244021.622op/s; +279508.279op/s] or [-4.703%; +5.387%]

scenario:plugin-claude-agent-sdk-compact-hook-indexed-26

unstable cpu_usage_percentage [-6.699%; +4.474%]
unstable execution_time [-308.418ms; +500.027ms] or [-4.348%; +7.049%]
unstable throughput [-48883.538op/s; +30389.483op/s] or [-6.516%; +4.051%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-24

unstable cpu_user_time [-478.476ms; +612.690ms] or [-4.411%; +5.648%]
unstable execution_time [-485.319ms; +616.110ms] or [-4.411%; +5.600%]

scenario:plugin-graphql-long-with-depth-off-26

unstable max_rss_usage [-13.478MB; +20.853MB] or [-7.115%; +11.008%]

scenario:plugin-graphql-long-with-depth-on-max-26

unstable max_rss_usage [-15.549MB; +31.657MB] or [-8.244%; +16.784%]

scenario:plugin-redis-mset-wide-26

unstable cpu_user_time [-169.267ms; +332.700ms] or [-4.939%; +9.708%]
unstable execution_time [-166.465ms; +333.869ms] or [-4.766%; +9.558%]
unstable throughput [-19559.747op/s; +8911.198op/s] or [-6.915%; +3.150%]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42005a60a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# Conflicts: # .github/CODEOWNERS # packages/dd-trace/src/opentracing/propagation/text_map.js # packages/dd-trace/test/opentracing/propagation/text_map.spec.js

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 660cb44f39

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov · 2026-09-03T15:22:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.68%. Comparing base (2015713) to head (79fa291).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #10117       +/-   ##
===========================================
+ Coverage   87.23%   98.68%   +11.44%     
===========================================
  Files         996     1008       +12     
  Lines      153441   158648     +5207     
  Branches       74       74               
===========================================
+ Hits       133857   156562    +22705     
+ Misses      19584     2086    -17498

Flag	Coverage Δ
ai-guard	`65.13% <58.98%> (-0.08%)`	⬇️
apm-capabilities	`63.85% <100.00%> (+0.15%)`	⬆️
apm-integrations	`81.51% <84.28%> (+0.03%)`	⬆️
appsec	`59.01% <82.95%> (+0.10%)`	⬆️
debugger	`69.68% <55.62%> (-0.17%)`	⬇️
instrumentation	`53.78% <78.14%> (+0.10%)`	⬆️
llmobs	`79.07% <73.67%> (+0.81%)`	⬆️
master-coverage	`98.68% <100.00%> (?)`
openfeature	`66.30% <55.11%> (-0.12%)`	⬇️
platform	`69.33% <67.80%> (+<0.01%)`	⬆️
profiling	`66.62% <52.24%> (-0.16%)`	⬇️
serverless	`65.81% <76.18%> (+0.06%)`	⬆️
test-optimization	`82.83% <82.48%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Guard own-property checks with cheap membership probes so ordinary tag maps avoid three Object.hasOwn calls while inherited sampling tags remain ignored.\n\nNode 24 finish-immediately-with-tags versus the previous implementation: throughput +10.77%, user CPU -8.45%. Versus the exact master baseline: throughput -0.04%, user CPU -0.46%.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eef8dcdba6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd8c1925d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-09T12:47:35Z

+    if (!span) return
+
+    const context = this._getContext(span)
+    if (isProductForceKeep(context)) return


Preserve inherited product mechanisms before manual overrides

When a standard OTel parent carries dd=s:2;t.dm:-5 or t.dm:-13, _convertOtelContextToDatadog() parses s but initializes _sampling with only the priority, leaving mechanism undefined; this guard therefore fails to recognize the inherited AppSec/AI Guard force-keep, and a later manual.drop tag now overwrites it. The fresh evidence beyond the earlier local product-force-keep finding is this standard OTel conversion path, whereas native W3C extraction does populate _sampling.mechanism; preserve t.dm during OTel parent conversion so both single- and batch-tag helpers retain the product decision.

Useful? React with 👍 / 👎.

vpellan · 2026-09-09T13:08:01Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77ef7a56ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-09T13:19:57Z

    spanContext._ddContext._sampling = { priority: samplingPriority }
+    if (samplingMechanism !== undefined) spanContext._ddContext._sampling.mechanism = samplingMechanism


Preserve the OTel decision-maker trace tag

When a standard OTel parent carries dd=s:2;t.dm:-5, the new serialization path records 5 only in _sampling.mechanism; it never writes _dd.p.dm into _trace.tags because the raw t.dm is copied into span tags instead. Consequently the local trace chunk omits its inherited decision maker, and with Datadog-only injection #injectTags() omits it from x-datadog-tags as well. Fresh evidence after the earlier override fix is that the final assignment here updates only _sampling; preserve the corresponding trace tag as native tracecontext extraction does.

Useful? React with 👍 / 👎.

I removed this follow-up because preserving _dd.p.dm in Datadog-native trace tags is outside the distributed ot.th/ot.rv scope.

chatgpt-codex-connector · 2026-09-09T13:19:57Z

+    if (selectedPriority === undefined) {
+      selectedSpanContext._sampling.priority = w3cSpanContext._sampling.priority
+      selectedSpanContext._sampling.mechanism = w3cSpanContext._sampling.mechanism
+      selectedSpanContext._trace.tags['_dd.p.dm'] = w3cSpanContext._trace.tags['_dd.p.dm']


Copy W3C decision metadata when B3 already has a priority

When B3 wins extraction and supplies sampled=1 or sampled=0, selectedPriority is already defined, so an agreeing same-trace W3C context's mechanism and _dd.p.dm are not copied. The W3C tracestate is still forwarded, but the local trace chunk and any Datadog-only downstream injection lose the inherited decision maker. Fresh evidence after the missing-priority fix is that this branch copies the metadata only for undefined priorities; agreeing defined priorities need the same metadata merge.

Useful? React with 👍 / 👎.

I removed this follow-up because agreeing B3/W3C contexts already retain the raw ot tracestate without copying Datadog-only decision metadata.

vpellan · 2026-09-09T13:28:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b99215db84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vpellan · 2026-09-09T13:57:18Z

@codex review

chatgpt-codex-connector · 2026-09-09T14:05:45Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: ca108b1856

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca108b1856

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vpellan · 2026-09-09T14:35:27Z

@codex review

chatgpt-codex-connector · 2026-09-09T14:41:15Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 79fa291ea0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-09T14:45:36Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 79fa291ea0

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector · 2026-09-09T14:54:18Z

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 79fa291ea0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-09T14:54:30Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 79fa291ea0

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

First implementation for OTel sampling support

49eb625

vpellan requested review from a team as code owners September 2, 2026 14:21

vpellan requested a review from BridgeAR September 2, 2026 14:21

github-actions Bot added the semver-minor label Sep 2, 2026

CODEOWNERS

5785a9b

vpellan requested a review from a team as a code owner September 2, 2026 14:25

chatgpt-codex-connector Bot reviewed Sep 2, 2026

View reviewed changes

vpellan added 5 commits September 3, 2026 15:14

fix(otel): generate sampling state for OTel propagation

9a7dfdd

fix(sampling): preserve committed decision metadata during checks

af0fa51

fix(standalone): mark extracted force-keeps non-probability

1186c76

fix(propagation): merge matching W3C tracestate into B3 context

30ab81c

perf(sampling): defer OTel decision metadata until propagation

42005a6

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread packages/dd-trace/src/opentelemetry/span_context.js

Comment thread packages/dd-trace/src/priority_sampler.js

Comment thread packages/dd-trace/src/opentracing/propagation/text_map.js Outdated

Comment thread packages/dd-trace/src/knuth-hash.js

vpellan added 4 commits September 3, 2026 16:12

Merge branch 'master' into vpellan/otel-threshold-random-value

660cb44

# Conflicts: # .github/CODEOWNERS # packages/dd-trace/src/opentracing/propagation/text_map.js # packages/dd-trace/test/opentracing/propagation/text_map.spec.js

fix(otel): preserve standard parent tracestate

46548fb

fix(sampling): refresh manual decision maker

e8d4fd6

fix(propagation): clear conflicting OTel thresholds

9c18613

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread packages/dd-trace/src/otel-sampling.js

vpellan added 2 commits September 3, 2026 16:38

refactor(sampling): use kebab-case filenames

f9ff0ad

fix(otel): ignore uncommitted sampling probe rates

8fa5940

fix(otel): preserve inherited tracestate member order

9dc3f5d

vpellan added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Sep 4, 2026

Merge branch 'master' into vpellan/otel-threshold-random-value

cf02963

vpellan added 6 commits September 8, 2026 17:32

test(propagation): preserve agreeing rule sampling state

6e6f7f0

test(sampling): codify allowed rate-limit semantics

a8937f5

fix(propagation): clear stale state for B3 debug

3237de8

fix(propagation): inherit W3C decision metadata

ddf0605

Merge branch 'master' into vpellan/otel-threshold-random-value

875ae2e

chatgpt-codex-connector Bot reviewed Sep 9, 2026

View reviewed changes

Comment thread packages/dd-trace/src/opentracing/propagation/text_map.js

fix(propagation): merge implicit W3C state into winner

dd8c192

chatgpt-codex-connector Bot reviewed Sep 9, 2026

View reviewed changes

fix(otel): preserve inherited sampling mechanism

77ef7a5

chatgpt-codex-connector Bot reviewed Sep 9, 2026

View reviewed changes

vpellan added 2 commits September 9, 2026 15:24

fix(otel): preserve inherited decision maker tag

e74e7cc

fix(propagation): inherit agreeing W3C decision metadata

b99215d

chatgpt-codex-connector Bot reviewed Sep 9, 2026

View reviewed changes

Comment thread packages/dd-trace/src/opentelemetry/tracer.js

Comment thread packages/dd-trace/src/priority_sampler.js

Comment thread packages/dd-trace/src/opentracing/propagation/tracestate.js Outdated

vpellan added 3 commits September 9, 2026 15:51

fix(otel): map inherited Datadog tracestate fields

8444a9a

fix(propagation): hydrate Datadog sampling mechanism

fade28a

fix(propagation): preserve state after oversized member

ca108b1

chatgpt-codex-connector Bot reviewed Sep 9, 2026

View reviewed changes

Comment thread packages/dd-trace/src/opentelemetry/tracer.js Outdated

Comment thread packages/dd-trace/src/priority_sampler.js

Comment thread packages/dd-trace/src/opentracing/propagation/text_map.js Outdated

vpellan added 3 commits September 9, 2026 16:26

refactor(otel): keep unrelated tracestate fields opaque

754e47f

refactor(otel): keep decision maker in tracestate

2ea52be

refactor(propagation): keep agreeing metadata opaque

79fa291

		spanContext._ddContext._sampling = { priority: samplingPriority }
		if (samplingMechanism !== undefined) spanContext._ddContext._sampling.mechanism = samplingMechanism

Uh oh!

Conversation

vpellan commented Sep 2, 2026

What does this PR do?

Motivation

Additional Notes

Uh oh!

chatgpt-codex-connector Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

dd-octo-sts Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

datadog-prod-us1-5 Bot commented Sep 2, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pr-commenter Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

Unstable benchmarks

scenario:appsec-appsec-enabled-with-attacks-20

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

scenario:debugger-line-probe-with-snapshot-minimal-26

scenario:encoders-0.4-immediate-flush-20

scenario:llmobs-encode-unicode-ascii-20

scenario:llmobs-encode-unicode-mixed-20

scenario:plugin-aws-sdk-extract-response-body-24

scenario:plugin-claude-agent-sdk-compact-hook-indexed-26

scenario:plugin-graphql-long-with-depth-and-collapse-off-24

scenario:plugin-graphql-long-with-depth-off-26

scenario:plugin-graphql-long-with-depth-on-max-26

scenario:plugin-redis-mset-wide-26

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

vpellan commented Sep 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

chatgpt-codex-connector Bot commented Sep 2, 2026 •

edited

Loading

dd-octo-sts Bot commented Sep 2, 2026 •

edited

Loading

datadog-prod-us1-5 Bot commented Sep 2, 2026 •

edited by datadog-official Bot

Loading

pr-commenter Bot commented Sep 2, 2026 •

edited

Loading

codecov Bot commented Sep 3, 2026 •

edited

Loading